Commits on Sep 15, 2020

1. *: improve latency when streaming series from Prometheus …

   I've found that when requesting many series (in the order of ten
   thousands), the Thanos sidecar spends half of its time computing the
   number of received series. To calculate the number of series, it needs
   to build a label-based identifier for each chunked series and compare it
   with the previous identifier. Eventually this number is only used for
   logging and tracing so it doesn't feel like it's worth the penalty.
   
   This change adds an histogram metric,
   `thanos_sidecar_prometheus_store_received_frames`, which tracks the
   number of frames per request received from the Prometheus remote read
   API (buckets: 10, 100, 1000, 10000, 100000). It can be used to evaluate
   whether expensive Series requests are being performed.
   
   Signed-off-by: Simon Pasquier <spasquie@redhat.com>

   

   simonpasquier committed Sep 15, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for f2ab444
   • Browse repository at this point

   Copy the full SHA

   f2ab444 View commit details

   Browse the repository at this point in the history