Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact: Fix web.prefix-header to use &wc.prefixHeaderName #3184

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Compact: Fix web.prefix-header to use &wc.prefixHeaderName #3184

merged 2 commits into from
Sep 18, 2020

Conversation

daksh-sagar
Copy link
Contributor

@daksh-sagar daksh-sagar commented Sep 17, 2020

Signed-off-by: Daksh Sagar daksh.sagar@yahoo.com

Fix web.prefix-header to use &wc.prefixHeaderName instead of &wc.externalPrefix

Fixes #3156

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

cmd/thanos/config.go in registerFlag method, make cmd.Flag("web.prefix-header", "...", "...") use the prefixHeaderName field instead of externalPrefix

Verification

@daksh-sagar
Copy link
Contributor Author

@yeya24 Can you see please see if this is alright?

Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution!

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)
Can you rebase? Then we can merge

Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Signed-off-by: Daksh Sagar <daksh.sagar@yahoo.com>
Signed-off-by: Daksh Sagar <daksh.sagar@yahoo.com>
@kakkoyun kakkoyun merged commit 78c122f into thanos-io:master Sep 18, 2020
@bwplotka
Copy link
Member

For the future, changelog item is too code specific, we need to make sure it's understandable for a user e.g: Compactor: Fixed support for web.external-prefixfor Compactor UI. Also it should be infixed` category.

I fixed it here, so this is just for learning purposes (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compact: cli arg web.external-prefix is ignored
5 participants