Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compact: Added index size limiting planner detecting output index size over 64GB. #3410

Merged
merged 3 commits into from
Nov 9, 2020

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Nov 4, 2020

Chained with #3409

Fixes: #1424

Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com

Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other additions looks perfect

cmd/thanos/compact.go Show resolved Hide resolved
@bwplotka
Copy link
Member Author

bwplotka commented Nov 6, 2020

Addressed all (:

Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@bwplotka bwplotka changed the base branch from compmarker to master November 6, 2020 16:00
…e over 64GB.

Fixes: #1424

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
@bwplotka bwplotka force-pushed the index-size-planner branch 2 times, most recently from e5b5d64 to 3bbf7b0 Compare November 9, 2020 16:08
@bwplotka
Copy link
Member Author

bwplotka commented Nov 9, 2020

I need to fix some e2e tests (actually extend them to test index size limiting)

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
@bwplotka
Copy link
Member Author

bwplotka commented Nov 9, 2020

Should be fixed!

@bwplotka bwplotka merged commit ce72bfe into master Nov 9, 2020
@bwplotka bwplotka deleted the index-size-planner branch November 9, 2020 19:08
Oghenebrume50 pushed a commit to Oghenebrume50/thanos that referenced this pull request Dec 7, 2020
…e over 64GB. (thanos-io#3410)

* compact: Added index size limiting planner detecting output index size over 64GB.

Fixes: thanos-io#1424

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>

* Addressed comments; added changelog.

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>

* Skipped flaky test.

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compactor - "write postings: exceeding max size of 64GiB"
2 participants