Refactor flag parsing and runRule arguments for ruler #3993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
reviewed
Mar 30, 2021
bwplotka
previously approved these changes
Apr 6, 2021
docs/components/compact.md
Outdated
| @@ -428,6 +428,10 @@ Flags: | |||
| Prometheus relabel-config syntax. See format | |||
| details: | |||
| https://prometheus.io/docs/prometheus/latest/configuration/configuration/#relabel_config | |||
| --web.route-prefix="" Prefix for API and UI endpoints. This allows | |||
There was a problem hiding this comment.
This is great, but let's make sure this flag is handled and not registered and not used, by accident (:
docs/components/rule.md
Outdated
| @@ -269,73 +269,16 @@ Flags: | |||
| TLS CA to verify clients against. If no client | |||
| CA is specified, there is no client | |||
| verification on server side. (tls.NoClientCert) | |||
| --label=<name>="<value>" ... | |||
There was a problem hiding this comment.
Let's review manually here, but @idoqo can you add an issue on Thanos for the task to print flags in sorted order. (Let's make sure to provide the use case).
This was referenced Apr 8, 2021
Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
idoqo
force-pushed
the
run-rule-refactor
branch
from
5f88fff
to
2fa83f0
Compare
bwplotka
approved these changes
Apr 16, 2021
There was a problem hiding this comment.
Nice! Now it's super easy to see what was added 🤗 Thanks to you @idoqo and @wiardvanrij for adding sorting!
someshkoli
pushed a commit
to someshkoli/thanos
that referenced
this pull request
Apr 21, 2021
* Refactor flag parsing and runRule arguments for ruler Signed-off-by: Michael Okoko <okokomichaels@outlook.com> * Regenerate sorted docs for rule and compactor Signed-off-by: Michael Okoko <okokomichaels@outlook.com> Signed-off-by: someshkoli <kolisomesh27@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Okoko okokomichaels@outlook.com
Changes
runRulearguments into a config struct which can then be passed to the function instead.query.*andalertmanagers.*. (As per cmd/thanos: Refactor run*(...) functions. #2248 and similar to Refactor of commands and flag parsing #2267).