receive: Improved Performance for err path. #4085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` benchstat -delta-test=none ../_dev/thanos/2021/receive2/impr5-go1.16.3.txt ../_dev/thanos/2021/receive2/errimpr1-go1.16.3.txt name old time/op new time/op delta HandlerReceiveHTTP/typical_labels_under_1KB,_500_of_them/OK-12 1.22ms ± 0% 1.05ms ± 0% -13.97% HandlerReceiveHTTP/typical_labels_under_1KB,_500_of_them/conflict_errors-12 5.84ms ± 0% 1.26ms ± 0% -78.46% HandlerReceiveHTTP/typical_labels_under_1KB,_5000_of_them/OK-12 12.8ms ± 0% 11.3ms ± 0% -11.54% HandlerReceiveHTTP/typical_labels_under_1KB,_5000_of_them/conflict_errors-12 59.4ms ± 0% 12.8ms ± 0% -78.39% HandlerReceiveHTTP/extremely_large_label_value_10MB,_10_of_them/OK-12 109ms ± 0% 97ms ± 0% -11.16% HandlerReceiveHTTP/extremely_large_label_value_10MB,_10_of_them/conflict_errors-12 1.44s ± 0% 0.10s ± 0% -93.25% name old alloc/op new alloc/op delta HandlerReceiveHTTP/typical_labels_under_1KB,_500_of_them/OK-12 1.20MB ± 0% 1.20MB ± 0% -0.69% HandlerReceiveHTTP/typical_labels_under_1KB,_500_of_them/conflict_errors-12 4.34MB ± 0% 1.36MB ± 0% -68.54% HandlerReceiveHTTP/typical_labels_under_1KB,_5000_of_them/OK-12 13.3MB ± 0% 13.2MB ± 0% -0.67% HandlerReceiveHTTP/typical_labels_under_1KB,_5000_of_them/conflict_errors-12 44.6MB ± 0% 14.9MB ± 0% -66.67% HandlerReceiveHTTP/extremely_large_label_value_10MB,_10_of_them/OK-12 120MB ± 0% 120MB ± 0% -0.00% HandlerReceiveHTTP/extremely_large_label_value_10MB,_10_of_them/conflict_errors-12 592MB ± 0% 120MB ± 0% -79.77% name old allocs/op new allocs/op delta HandlerReceiveHTTP/typical_labels_under_1KB,_500_of_them/OK-12 5.10k ± 0% 4.59k ± 0% -9.83% HandlerReceiveHTTP/typical_labels_under_1KB,_500_of_them/conflict_errors-12 25.1k ± 0% 7.6k ± 0% -69.67% HandlerReceiveHTTP/typical_labels_under_1KB,_5000_of_them/OK-12 50.4k ± 0% 45.4k ± 0% -9.93% HandlerReceiveHTTP/typical_labels_under_1KB,_5000_of_them/conflict_errors-12 250k ± 0% 75k ± 0% -69.96% HandlerReceiveHTTP/extremely_large_label_value_10MB,_10_of_them/OK-12 89.0 ± 0% 78.0 ± 0% -12.36% HandlerReceiveHTTP/extremely_large_label_value_10MB,_10_of_them/conflict_errors-12 368 ± 0% 201 ± 0% -45.38% ``` Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
|
With this, it's as minimal as it can be I think |
yeya24
approved these changes
Apr 20, 2021
| @@ -1293,7 +1293,7 @@ func Heap(dir string) (err error) { | |||
| return err | |||
| } | |||
|
|
|||
| f, err := os.Create(filepath.Join(dir, "impr5-go1.16.3.pprof")) | |||
| f, err := os.Create(filepath.Join(dir, "errimpr1-go1.16.3.pprof")) | |||
There was a problem hiding this comment.
Yes, I provably should remove those before merging but those are super useful for checking leaks (:
onprem
reviewed
Apr 21, 2021
bwplotka
commented
Apr 21, 2021
clyang82
pushed a commit
to stolostron/thanos
that referenced
this pull request
Apr 27, 2021
``` benchstat -delta-test=none ../_dev/thanos/2021/receive2/impr5-go1.16.3.txt ../_dev/thanos/2021/receive2/errimpr1-go1.16.3.txt name old time/op new time/op delta HandlerReceiveHTTP/typical_labels_under_1KB,_500_of_them/OK-12 1.22ms ± 0% 1.05ms ± 0% -13.97% HandlerReceiveHTTP/typical_labels_under_1KB,_500_of_them/conflict_errors-12 5.84ms ± 0% 1.26ms ± 0% -78.46% HandlerReceiveHTTP/typical_labels_under_1KB,_5000_of_them/OK-12 12.8ms ± 0% 11.3ms ± 0% -11.54% HandlerReceiveHTTP/typical_labels_under_1KB,_5000_of_them/conflict_errors-12 59.4ms ± 0% 12.8ms ± 0% -78.39% HandlerReceiveHTTP/extremely_large_label_value_10MB,_10_of_them/OK-12 109ms ± 0% 97ms ± 0% -11.16% HandlerReceiveHTTP/extremely_large_label_value_10MB,_10_of_them/conflict_errors-12 1.44s ± 0% 0.10s ± 0% -93.25% name old alloc/op new alloc/op delta HandlerReceiveHTTP/typical_labels_under_1KB,_500_of_them/OK-12 1.20MB ± 0% 1.20MB ± 0% -0.69% HandlerReceiveHTTP/typical_labels_under_1KB,_500_of_them/conflict_errors-12 4.34MB ± 0% 1.36MB ± 0% -68.54% HandlerReceiveHTTP/typical_labels_under_1KB,_5000_of_them/OK-12 13.3MB ± 0% 13.2MB ± 0% -0.67% HandlerReceiveHTTP/typical_labels_under_1KB,_5000_of_them/conflict_errors-12 44.6MB ± 0% 14.9MB ± 0% -66.67% HandlerReceiveHTTP/extremely_large_label_value_10MB,_10_of_them/OK-12 120MB ± 0% 120MB ± 0% -0.00% HandlerReceiveHTTP/extremely_large_label_value_10MB,_10_of_them/conflict_errors-12 592MB ± 0% 120MB ± 0% -79.77% name old allocs/op new allocs/op delta HandlerReceiveHTTP/typical_labels_under_1KB,_500_of_them/OK-12 5.10k ± 0% 4.59k ± 0% -9.83% HandlerReceiveHTTP/typical_labels_under_1KB,_500_of_them/conflict_errors-12 25.1k ± 0% 7.6k ± 0% -69.67% HandlerReceiveHTTP/typical_labels_under_1KB,_5000_of_them/OK-12 50.4k ± 0% 45.4k ± 0% -9.93% HandlerReceiveHTTP/typical_labels_under_1KB,_5000_of_them/conflict_errors-12 250k ± 0% 75k ± 0% -69.96% HandlerReceiveHTTP/extremely_large_label_value_10MB,_10_of_them/OK-12 89.0 ± 0% 78.0 ± 0% -12.36% HandlerReceiveHTTP/extremely_large_label_value_10MB,_10_of_them/conflict_errors-12 368 ± 0% 201 ± 0% -45.38% ``` Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com
Changes
Verification