Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick: Match external labels in exemplars API (#4123) #4127

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

kakkoyun
Copy link
Member

  • match external labels in exemplars API

Signed-off-by: yeya24 yb532204897@gmail.com

  • update changelog

Signed-off-by: yeya24 yb532204897@gmail.com

  • fix lint

Signed-off-by: yeya24 yb532204897@gmail.com

  • fix flaky tests

Signed-off-by: yeya24 yb532204897@gmail.com

  • Fix changelog

Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com

Fixes #4116

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

cc @yeya24

* match external labels in exemplars API

Signed-off-by: yeya24 <yb532204897@gmail.com>

* update changelog

Signed-off-by: yeya24 <yb532204897@gmail.com>

* fix lint

Signed-off-by: yeya24 <yb532204897@gmail.com>

* fix flaky tests

Signed-off-by: yeya24 <yb532204897@gmail.com>

* Fix changelog

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
@kakkoyun kakkoyun requested a review from a team April 30, 2021 11:54
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kakkoyun kakkoyun merged commit 833931a into thanos-io:main Apr 30, 2021
@kakkoyun kakkoyun deleted the patch-0.20.1 branch April 30, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

query: query_exemplars does not account for external labels
3 participants