-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests that excercise Thanos Receive edge cases #4362
Add integration tests that excercise Thanos Receive edge cases #4362
Conversation
…nts, adds IngestingReceiver testing type Signed-off-by: Ian Billett <ibillett@redhat.com>
Thanks for this! I am thinking that maybe let's convert |
Signed-off-by: Ian Billett <ibillett@redhat.com>
Nice idea @GiedriusS 👍 I've updated the integration tests to fail on the 'correct' value. PTAL. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tests, thanks for those,
But I would not add new helper, see comment 🙈
Signed-off-by: Ian Billett <ibillett@redhat.com>
…ration test value Signed-off-by: Ian Billett <ibillett@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it, thanks!
Sorry for the massive lag on checking those!
Changes
This PR adds 3 new integration test scenarios for Thanos Receive.
router_replication
androuter_tree
both currently fail againstmain
.See #4359 for discussion.
Verification
Tests are failing 🙃