Query: Fix panic on stores endpoint #4754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Skip an endpoint from stores if component type is nil - Simplify - pass only endpoint status func instead of endpoints Signed-off-by: Matej Gera <matejgera@gmail.com>
Signed-off-by: Matej Gera <matejgera@gmail.com>
yeya24
previously approved these changes
Oct 8, 2021
I'd leave that to the maintainers' discretion, I can point this to the release as well if that's preferred. For me, this is not that critical, since it requires a specific scenario with multiple unreachable / misconfigured stores. I think so far we've seen only one report of the issue. |
…s-invalid-endpoint Signed-off-by: Matej Gera <matejgera@gmail.com>
yeya24
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
As was reported in #4743, it is possible that if stores provided to querier are not available (e.g. the store is down, the address is incorrect etc.), trying to call the
/storesendpoint can result in panic. This is due to the fact that the status of the endpoint is missing information on component type. The suggested way to resolve this is to ignore such stores.Resolves #4743.
Verification
Added tests to verify
/storesbehaves as expected.