query: pass queryURL along to the UI #4847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
force-pushed
the
pass_queryURL_thanos
branch
2 times, most recently
from
cd5534c
to
d76e7b8
Compare
Pass `queryURL` to the UI to have proper URLs in the React UI. Without this, all URLs are set to `http://localhost:10902` i.e. the default value set in `config.ts`. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
force-pushed
the
pass_queryURL_thanos
branch
from
d76e7b8
to
e1a19b9
Compare
|
@squat this is needed for the next version to avoid broken links in targets/rules pages because the link is |
squat
previously approved these changes
Nov 12, 2021
|
@GiedriusS can you rebase and we can merge? |
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Done 👍 |
|
Not sure why but after merging this, the changelog for #4848 is missing. |
GiedriusS
added a commit
to GiedriusS/thanos
that referenced
this pull request
Nov 16, 2021
Pass `queryURL` to the UI to have proper URLs in the React UI. Without this, all URLs are set to `http://localhost:10902` i.e. the default value set in `config.ts`. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Pass
queryURLto the UI to have proper URLs in the React UI. Withoutthis, all URLs are set to
http://localhost:10902i.e. the defaultvalue set in
config.ts.Verification
Started Thanos via the quickstart script and checked that http://localhost:10904/rules, for example, has proper, clickable URLs.