query: add --endpoint-strict flag to statically configure endpoints
#4874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hitanshu Mehta <hitanshu99amehta@gmail.com>
hitanshu-mehta
changed the title
--endpoint-strict flag to add statically configured endpoints--endpoint-strict flag to statically configure endpoints
GiedriusS
previously approved these changes
Nov 16, 2021
matej-g
reviewed
Nov 16, 2021
Comment on lines
+406
to
+411
| for _, endpoint := range strictEndpoints { | ||
| if dns.IsDynamicNode(endpoint) { | ||
| return errors.Errorf("%s is a dynamically specified endpoint i.e. it uses SD and that is not permitted under strict mode. Use --endpoint for this", endpoint) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Nit: Having this right after doing the same for strictStores would read tiny bit better 😊
Signed-off-by: Hitanshu Mehta <hitanshu99amehta@gmail.com>
GiedriusS
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes 3rd task from this list.
Changes
--endpoint-strictflag (similar to--store-strict) which can be used to add statically configured endpoints.