Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing force tracing with Jaeger #4918

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Conversation

deniszh
Copy link
Contributor

@deniszh deniszh commented Dec 1, 2021

This is replacement for stale PR #4018 by @conorevans

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Make baggage key lowercase for Jaeger support. Per Jaeger documentation:

Limitation: since HTTP headers don’t preserve the case, Jaeger recommends baggage keys to be lowercase-kebab-case, e.g. my-baggage-key-1.

Verification

Not sure if it's easy to test. As original author, I'm not sure if spinning Jaeger and Thanos worth to test that.

Signed-off-by: Denys Zhdanov <denys.zhdanov@adevinta.com>
pkg/tracing/jaeger/jaeger.go Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
Signed-off-by: Denys Zhdanov <denys.zhdanov@adevinta.com>

fixing formatting

Signed-off-by: Denys Zhdanov <denys.zhdanov@adevinta.com>

fixing formatting
Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!

@squat squat enabled auto-merge (squash) December 1, 2021 17:44
@GiedriusS
Copy link
Member

CircleCI seems dead, merging with admin rights

@GiedriusS GiedriusS merged commit c0a3f14 into thanos-io:main Dec 2, 2021
aarontams pushed a commit to aarontams/thanos that referenced this pull request Dec 5, 2021
* lowering ForceTracingBaggageKey to work with Jaeger

Signed-off-by: Denys Zhdanov <denys.zhdanov@adevinta.com>

* Adding CHANGELOG entry

Signed-off-by: Denys Zhdanov <denys.zhdanov@adevinta.com>

fixing formatting

Signed-off-by: Denys Zhdanov <denys.zhdanov@adevinta.com>

fixing formatting

Co-authored-by: Denys Zhdanov <denys.zhdanov@adevinta.com>
Signed-off-by: aaron.tam <aaron.tam@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants