rule: Added ability to specify multiple remote write targets. #4927
Conversation
test/e2e/rule_test.go
Outdated
| URL: &common_cfg.URL{URL: rwURL}, | ||
| Name: "thanos-receiver", | ||
| }) | ||
| }}) |
There was a problem hiding this comment.
Worth a test case for multiple remote write targets?
There was a problem hiding this comment.
Hm. maybe not, since it's the Agent logic? We don't want to test Agent really
There was a problem hiding this comment.
whatever, let's do it ;p
This is mainly for non surprising remote write YAML format, but also for ability to add more targets, similar to agent supported model. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
|
PTAL @yeya24 |
|
@hanjm wanna help in review/approve? Your reviews counts! (: |
…-io#4927) This is mainly for non surprising remote write YAML format, but also for ability to add more targets, similar to agent supported model. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
…-io#4927) This is mainly for non surprising remote write YAML format, but also for ability to add more targets, similar to agent supported model. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: wenmaoba <wenmaoba@tencent.com>
|
Hello, Wasn't this change a I will confirm after fixing tomorrow my rule component on my side, but after upgrading from v0.24 to v0.25: I have downgraded to v0.24 before switching to array, but I think changelog can be improved if that's the case. EDIT: I was wrong, it errored correctly, still a breaking change though: |
|
EDIT2 ^^': I was right, and here is the diff: url: http://e2e_test_rule_remote_write-receive-1:8081/api/v1/receive
name: thanos-receiver
follow_redirects: falseon 0.25, a valid one is: remote_write:
- url: http://e2e_test_rule_remote_write-receive-1:8081/api/v1/receive
name: thanos-receiver
follow_redirects: falseWhich means that version 0.25 with a config for 0.24 is not making the ruler crash but not taking the remote_write config, |
This is mainly for non surprising remote write YAML format, but also for ability
to add more targets, similar to agent supported model.
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com