proposal: Deprecate/Remove gossip clustering for Thanos. #493
Conversation
bwplotka
force-pushed
the
gossip-remove-proposal
branch
from
b37491d
to
598588a
Compare
docs/proposals/gossip-removal.md
Outdated
|
|
||
| ## Goals | ||
|
|
||
| * Deprecate gossip protocol or remove it immediately (TODO: Gather input here!) |
There was a problem hiding this comment.
I need some feedback on how to handle that. I feel like just removal would the best option in terms of maintainance and simplicity. However if someone already is running Thanos in production this might distrupt a lot. So maybe do slow deprecate until some "notice time"?
There was a problem hiding this comment.
My personal take is that Thanos is a very young project and this change is overall for the better so I think a hard break here is fine.
There was a problem hiding this comment.
I tend to agree, publicly declare deprication and the plan as we work on file-sd and then remove once file-sd has been proven out fully.
Users can always take old images from docker hub if needed whilst we move forward.
There was a problem hiding this comment.
Updated doc accordingly
bwplotka
force-pushed
the
gossip-remove-proposal
branch
from
598588a
to
cddb3ed
Compare
docs/proposals/gossip-removal.md
Outdated
| * Alternatively just remove it? (we are still in RC) | ||
|
|
||
| ### Backwards compatibility | ||
|
|
There was a problem hiding this comment.
Could take the gossip code and move to a new project that writes to file-sd if people are really keen on keeping it going. However, I would leave this to the community if they feel it is needed as supporting this would be as much work as supporting gossip within thanos
|
👍 Great proposal. I think if we can avoid gossip, we should definitely do that. |
|
Do you have any particular plans/dates for implementing this? Do you need any help? |
|
Worth mentioning in the proposal adding DNS SD as well #492 (comment) |
bwplotka
force-pushed
the
gossip-remove-proposal
branch
2 times, most recently
from
165b032
to
1f2d913
Compare
docs/proposals/gossip-removal.md
Outdated
| * Add File Service Discovery (SD): https://github.com/improbable-eng/thanos/issues/492 | ||
| * Remove gossip from the documentation, be clear what talks with what (!) | ||
| * Deprecate gossip in code. | ||
| * Remove gossip code and flags AFTER some time (month?) |
There was a problem hiding this comment.
I don't think there is any time to wait. Once file discovery is implemented and documented it should just be removed directly.
There was a problem hiding this comment.
Cool.
@ivan-valkov you were asking how blocking File SD issue is. (:
There was a problem hiding this comment.
I think we are all in agreement that we should move forward with this approach 👍
|
👍 |
This is quite a major change, so please give us feedback! Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
gossip-remove-proposal
branch
from
1f2d913
to
fe72535
Compare
…sip implementation removal. Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
|
Moved status to |
This is quite a major change, so please give us feedback!
Rendered view: https://github.com/improbable-eng/thanos/blob/gossip-remove-proposal/docs/proposals/gossip-removal.md
PTAL: @brancz @povilasv @fabxc @domgreen and others.
@mxinden @stuartnelson3 this may interest you.