Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude blocks marked for deletion #4970

Merged
merged 7 commits into from
Dec 20, 2021
Merged

Conversation

metonymic-smokey
Copy link
Contributor

@metonymic-smokey metonymic-smokey commented Dec 17, 2021

Fixes #4929

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Adding a flag to tools bucket ls to exclude blocks marked from deletion in the ls output.

Verification

Marked a block using tools bucket mark and verified that it did not appear in subsequent ls output.

@metonymic-smokey
Copy link
Contributor Author

Todo:

  1. Is an extra deleteDelay flag required to filter or should I set it to some default duration?
  2. Update docs and CHANGELOG.

Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
cmd/thanos/tools_bucket.go Outdated Show resolved Hide resolved
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
cmd/thanos/tools_bucket.go Outdated Show resolved Hide resolved
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey metonymic-smokey marked this pull request as ready for review December 19, 2021 03:20
@yeya24
Copy link
Contributor

yeya24 commented Dec 20, 2021

@metonymic-smokey LGTM. Can you add a changelog entry?

Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@yeya24 yeya24 changed the title Draft - Exclude blocks marked for deletion Exclude blocks marked for deletion Dec 20, 2021
@yeya24 yeya24 enabled auto-merge (squash) December 20, 2021 08:46
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yeya24 yeya24 merged commit c3325d6 into thanos-io:main Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flag to "thanos tools bucket ls" to exclude marked blocks
2 participants