Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom CA support for azure #4974

Merged
merged 3 commits into from
Dec 21, 2021
Merged

Conversation

clyang82
Copy link
Contributor

@clyang82 clyang82 commented Dec 20, 2021

Signed-off-by: clyang82 chuyang@redhat.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

use tls_config to connect with azure object store so that we can pass the certificate in.

part of #4820

Verification

Signed-off-by: clyang82 <chuyang@redhat.com>
Signed-off-by: clyang82 <chuyang@redhat.com>
wiardvanrij
wiardvanrij previously approved these changes Dec 20, 2021
Copy link
Member

@wiardvanrij wiardvanrij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

I also did not do it, but we really should make a generic wrapper for all the backends to use :D

@clyang82
Copy link
Contributor Author

Yes. Agree with your point. I have checked again. besides S3 and Azure, cos also need support tls_config. I will have a tls_config.go under objstore package so that it can be shared by other stores.

Signed-off-by: clyang82 <chuyang@redhat.com>
Copy link
Member

@wiardvanrij wiardvanrij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice!

@GiedriusS GiedriusS merged commit f7ea65b into thanos-io:main Dec 21, 2021
@clyang82 clyang82 deleted the custom_ca_azure branch December 22, 2021 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants