Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive: Added tenant ID tag for span #5148

Merged
merged 5 commits into from
Feb 12, 2022
Merged

Conversation

metonymic-smokey
Copy link
Contributor

@metonymic-smokey metonymic-smokey commented Feb 12, 2022

Fixes #5002

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Added tenant tag for Receive spans.

Verification

metonymic-smokey and others added 2 commits February 12, 2022 13:18
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
Copy link
Contributor Author

@yeya24 please review it when you're free.
Many thanks!

Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metonymic-smokey
Copy link
Contributor Author

Could you re-trigger the docs test? It's timing out.

@yeya24 yeya24 merged commit 6eedf76 into thanos-io:main Feb 12, 2022
Nicholaswang pushed a commit to Nicholaswang/thanos that referenced this pull request Mar 6, 2022
* added tenant id tag

Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>

* added changelog entry

Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>

* removed ctx var

Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
Signed-off-by: Nicholaswang <wzhever@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Receiver: instrument multitsdb tenant series tracing tag correctly
2 participants