Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receive] Export metrics about remote write requests per tenant #5424

Merged
merged 20 commits into from
Jun 23, 2022
Merged

[receive] Export metrics about remote write requests per tenant #5424

merged 20 commits into from
Jun 23, 2022

Commits on Jun 13, 2022

  1. Add write metrics to Thanos Receive 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    4e0a874 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. Let the middleware count inflight HTTP requests 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    81d03c3 View commit details
    Browse the repository at this point in the history

  2. Update Receive write metrics type & definition 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    8878786 View commit details
    Browse the repository at this point in the history

  3. Put option back in its place to avoid big diff 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    48d7ef0 View commit details
    Browse the repository at this point in the history

  4. Fetch tenant from headers instead of context 

    It might not be in the context in some cases.

Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    d33957f View commit details
    Browse the repository at this point in the history

  5. Delete unnecessary tenant parser middleware 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    33f4c6a View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2022

  1. Refactor & reuse code for HTTP instrumentation 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    3254efa View commit details
    Browse the repository at this point in the history

  2. Add missing copyright to some files 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    7f1cecb View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2022

  1. Add changelog entry for Receive & new HTTP metrics 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    51b6d21 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/thanos-io/thanos into dcama… 

    …ta/thanos-receive-write-metrics
    @douglascamata
    douglascamata committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    fe750d1 View commit details
    Browse the repository at this point in the history

  3. Remove TODO added by accident 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    643ffb9 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Make error handling code shorter 

    Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata @bwplotka
    douglascamata and bwplotka committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    607c4e9 View commit details
    Browse the repository at this point in the history

  2. Make switch statement simpler 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    95a7a37 View commit details
    Browse the repository at this point in the history

  3. Remove method label from timeseries' metrics 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    3b3592b View commit details
    Browse the repository at this point in the history

  4. Count samples of all series instead of each 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    2dd4592 View commit details
    Browse the repository at this point in the history

  5. Remove in-flight requests metric 

    Will add this in a follow-up PR to keep this small.

Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    0141ea9 View commit details
    Browse the repository at this point in the history

  6. Change timeseries/samples metrics to histograms 

    The buckets were picked based on the fact that Prometheus' default
remote write configuration
(see https://prometheus.io/docs/practices/remote_write/#memory-usage)
set a max of 500 samples sent per second.

Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    493ede8 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' of https://github.com/thanos-io/thanos into dcama… 

    …ta/thanos-receive-write-metrics
    @douglascamata
    douglascamata committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    26600c1 View commit details
    Browse the repository at this point in the history

  8. Fix Prometheus registry for histograms 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    c4662b5 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. Fix comment in NewHandler functions 

    There are now four metrics instead of five.

Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    77f7bf7 View commit details
    Browse the repository at this point in the history