Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add panel Query Concurrency to dashboard mixin. #5542

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

raptorsun
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

add a panel "Query Concurrency" to the dashboard mixin, showing the available capacity to serve concurrent queries.

Verification

add the dashboard to grafana to check it.

The panel should look like this:
Screenshot from 2022-07-26 22-55-42

@raptorsun
Copy link
Contributor Author

how to rerun the failing test? it seems like a transient error.

"steppedLine": false,
"targets": [
{
"expr": "max_over_time(thanos_query_concurrent_gate_queries_max{job=~\"$job\"}[5m]) - avg_over_time(thanos_query_concurrent_gate_queries_in_flight{job=~\"$job\"}[5m])",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"expr": "max_over_time(thanos_query_concurrent_gate_queries_max{job=~\"$job\"}[5m]) - avg_over_time(thanos_query_concurrent_gate_queries_in_flight{job=~\"$job\"}[5m])",
"expr": "max_over_time(thanos_query_concurrent_gate_queries_max{job=~\"$job\"}[$__rate_interval]) - avg_over_time(thanos_query_concurrent_gate_queries_in_flight{job=~\"$job\"}[$__rate_interval])",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Filip :) The PR has been updated accordingly.
In the same file there is a variable $interval. Is it equivalent to $__rate_interval ?

@douglascamata
Copy link
Contributor

Hey @raptorsun, can you have a look at the feedback so that we can proceed with merging your contribution, please? 🙏

To rerun the build in case it fails, you can push an empty commit. Here's how you can create an empty commit: git commit -s --allow-empty -m "Empty commit to trigger CI"

@douglascamata
Copy link
Contributor

Small tip: maybe rebasing with main can help reducing the random failures. We've been working on this recently.

@raptorsun
Copy link
Contributor Author

Small tip: maybe rebasing with main can help reducing the random failures. We've been working on this recently.

The PR has been rebased on latest main branch now.

douglascamata
douglascamata previously approved these changes Aug 5, 2022
Copy link
Contributor

@douglascamata douglascamata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

Thanks, @raptorsun!

Signed-off-by: Haoyu Sun <hasun@redhat.com>
Copy link
Collaborator

@matej-g matej-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this was forgotten, but looks good! Thanks!

@matej-g matej-g merged commit a244b5f into thanos-io:main Oct 27, 2022
ngraham20 pushed a commit to ngraham20/thanos that referenced this pull request May 18, 2023
Signed-off-by: Haoyu Sun <hasun@redhat.com>

Signed-off-by: Haoyu Sun <hasun@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants