Compact: Make GatherNoCompactionMarkFilter.NoCompactMarkedBlocks concurrency safe #5736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorwwwwwwwwwwwwwwwwwwww
force-pushed
the
compact-fix-crash
branch
from
2b83136
to
aed26bd
Compare
…urrency safe
This fixes a crash due to concurrent access.
concurrent map read and map write
fixes thanos-io#5735
Signed-off-by: Igor Wiedler <iwiedler@gitlab.com>
igorwwwwwwwwwwwwwwwwwwww
force-pushed
the
compact-fix-crash
branch
from
aed26bd
to
860e868
Compare
fpetkovski
approved these changes
Sep 28, 2022
matej-g
approved these changes
Sep 28, 2022
yeya24
reviewed
Sep 28, 2022
| @@ -1361,6 +1361,7 @@ type GatherNoCompactionMarkFilter struct { | |||
| bkt objstore.InstrumentedBucketReader | |||
| noCompactMarkedMap map[ulid.ULID]*metadata.NoCompactMark | |||
| concurrency int | |||
| mtx sync.Mutex | |||
There was a problem hiding this comment.
Is it better using rw mutex?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash due to concurrent access.
fixes #5735
Changes
GatherNoCompactionMarkFilter.NoCompactMarkedBlocksVerification
Let's see what CI says first.