Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: add query metrics to calls going through the Store API #5741

Merged
merged 37 commits into from
Oct 18, 2022
Merged

Query: add query metrics to calls going through the Store API #5741

merged 37 commits into from
Oct 18, 2022

Commits on Sep 16, 2022

  1. Implement granular query performance metrics for Thanos Query 

    These are grabbed from the data returned by multiple Store APIs after execution of a query.

Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    595b7e2 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. Merge branch 'main' of github.com:thanos-io/thanos into add-path-cont… 

    …ent-reloader

Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    ff5a716 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. Fix some linter warnings 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    f6e2511 View commit details
    Browse the repository at this point in the history

  2. Remove useless logs 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    193d76f View commit details
    Browse the repository at this point in the history

  3. Refactor query tests 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    86f56e0 View commit details
    Browse the repository at this point in the history

  4. Fix long function definition (newQuerier) 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    f0c1a22 View commit details
    Browse the repository at this point in the history

  5. Remove TODO comment 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    6803e4a View commit details
    Browse the repository at this point in the history

  6. Fix query tests 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    3b3bc0c View commit details
    Browse the repository at this point in the history

  7. Reformat query docs 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    2e8778d View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' of github.com:thanos-io/thanos into query-store-m… 

    …etrics
    @douglascamata
    douglascamata committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    d218f82 View commit details
    Browse the repository at this point in the history

  9. Remove useless return 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    a738407 View commit details
    Browse the repository at this point in the history

  10. Put back old query docs 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    9057263 View commit details
    Browse the repository at this point in the history

  11. Update query docs again 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    f0567a9 View commit details
    Browse the repository at this point in the history

  12. Fix e2e env name 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    792487f View commit details
    Browse the repository at this point in the history

  13. Retrigger CI 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    d373d28 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2022

  1. Add missing copyright notice. 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    3470ded View commit details
    Browse the repository at this point in the history

  2. Retrigger CI 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    63d45e8 View commit details
    Browse the repository at this point in the history

  3. Retrigger CI 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    2a4241d View commit details
    Browse the repository at this point in the history

  4. Bump wait time to twice scrape interval 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    e04acb2 View commit details
    Browse the repository at this point in the history

  5. Retrigger CI 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    8e999ba View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. Attempt to fix randomly failing test 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    6a097f0 View commit details
    Browse the repository at this point in the history

  2. Checking more metrics to ensure the store is ready 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    6131510 View commit details
    Browse the repository at this point in the history

  3. Clean up test 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    8bc38bb View commit details
    Browse the repository at this point in the history

  4. Do not record store api metrics when didn't touch series or samples 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    ffcc2d4 View commit details
    Browse the repository at this point in the history

  5. Retrigger CI 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    6a13a7f View commit details
    Browse the repository at this point in the history

  6. Also skip store api metrics on zero chunks touched 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    31a9db8 View commit details
    Browse the repository at this point in the history

  7. Update changelog 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    5568a14 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' of github.com:thanos-io/thanos into query-store-m… 

    …etrics
    @douglascamata
    douglascamata committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    5888877 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. Fix broken changelog after merge 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    dfc1cf9 View commit details
    Browse the repository at this point in the history

  2. Remove extra empty line 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    dd1c104 View commit details
    Browse the repository at this point in the history

  3. Refactor names and (un)exported types and fields 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    fed8bf2 View commit details
    Browse the repository at this point in the history

  4. Start listing metrics exported by Thanos Query 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    8f6a245 View commit details
    Browse the repository at this point in the history

  5. Rename pkg/store/metrics -> pkg/store/telemetry 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    65e94ee View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Merge branch 'main' of github.com:thanos-io/thanos into query-store-m… 

    …etrics
    @douglascamata
    douglascamata committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    8f1b75b View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. Merge branch 'main' of github.com:thanos-io/thanos into query-store-m… 

    …etrics

Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    d6125e7 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. Get rid of the pkg/store/telemetry package 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    0951370 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into query-store-metrics 

    Signed-off-by: Matej Gera <38492574+matej-g@users.noreply.github.com>
    @matej-g
    matej-g committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    5eda104 View commit details
    Browse the repository at this point in the history