created lru cache in querysharding pkg #5749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
pkg/querysharding/analyzer_test.go
Outdated
| for _, v := range value { | ||
| b.Run(fmt.Sprintf("query: %s", v.name), func(b *testing.B) { | ||
| for i := 0; i < b.N; i++ { | ||
| analyze.Analyze(v.expression) |
There was a problem hiding this comment.
errcheck: Error return value of analyze.Analyze is not checked
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
yeya24
requested changes
Oct 2, 2022
Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com>
Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com>
Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com>
yeya24
requested changes
Oct 2, 2022
yeya24
reviewed
Oct 2, 2022
Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com>
Rahulkumar2002
force-pushed
the
lru_cache
branch
from
3e26c46
to
1a1703c
Compare
yeya24
reviewed
Oct 2, 2022
Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com>
yeya24
reviewed
Oct 3, 2022
Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com>
Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com>
Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com>
Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com>
Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com>
yeya24
reviewed
Oct 7, 2022
Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com>
yeya24
reviewed
Oct 9, 2022
Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com>
Rahulkumar2002
force-pushed
the
lru_cache
branch
from
3f008bf
to
08674cc
Compare
Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com>
Rahulkumar2002
force-pushed
the
lru_cache
branch
from
0bedf43
to
cbcff58
Compare
yeya24
requested changes
Oct 12, 2022
Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com>
Rahulkumar2002
force-pushed
the
lru_cache
branch
from
5da6afa
to
eb62727
Compare
yeya24
reviewed
Oct 12, 2022
yeya24
approved these changes
Oct 12, 2022
utukJ
pushed a commit
to utukJ/thanos
that referenced
this pull request
Oct 13, 2022
* created lru cache in querysharding pkg Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com> * triggering linting & vetting Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com> * added cache in querysharding pkg Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com> * created CacheQueryAnalyzer in querysharding pkg Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com> * changed type of queryAnalyzer in queryfrontend pkg Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com> * cache in querysharding pkg with error Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com> * cache in querysharding pkg with error Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com> * removed typos in comments in analyzer.go Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com> * removed typos in comments in analyzer.go Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com> * cached queryanalyzer Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com> * cached query analysis in querysharding pkg Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com> * changed interface name from Analyze to Analyzer in analyzer.go Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com> * changed struct to interface in shard_query.go Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com> Signed-off-by: Rahul Kumar Jha <rahuljhakumar1600@gmail.com> Signed-off-by: utukj <utukphd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rahul Kumar Jha rahuljhakumar1600@gmail.com
Changes
Added a LRU cache in analyzer.go which is in querysharding pkg.
#5715