Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply @ modifier start and end in QF split interval middleware #5844

Merged
merged 3 commits into from
Nov 1, 2022

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Nov 1, 2022

Signed-off-by: Ben Ye benye@amazon.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Evaluate @ modifier during query frontend query splitting. Same as the change in Cortex cortexproject/cortex#4463

Verification

fpetkovski
fpetkovski previously approved these changes Nov 1, 2022
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
@matej-g matej-g enabled auto-merge (squash) November 1, 2022 16:07
@matej-g matej-g merged commit 5898fb8 into thanos-io:main Nov 1, 2022
@yeya24 yeya24 deleted the apply-at-modifier-qf branch November 1, 2022 16:13
ngraham20 pushed a commit to ngraham20/thanos that referenced this pull request May 18, 2023
…s-io#5844)

* apply @ modifier start and end in QF split interval middleware

Signed-off-by: Ben Ye <benye@amazon.com>

* fix lint

Signed-off-by: Ben Ye <benye@amazon.com>

* fix unit tests

Signed-off-by: Ben Ye <benye@amazon.com>

Signed-off-by: Ben Ye <benye@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants