compact: retry on sync metas error #5865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpetkovski
reviewed
Nov 11, 2022
As we are exposing the metric for it (retries) and the interval is not low by default, I think it's better to leave it to users by configuring the |
fpetkovski
previously approved these changes
Nov 12, 2022
As SyncMetas is surrounded by Repeat func and can return retry errors, in some cases (like S3) errors (network issue, timeout, etc.) can be retried. Signed-off-by: Seena Fallah <seenafallah@gmail.com>
clwluvw
force-pushed
the
sync-err-retry
branch
from
450d29d
to
48dece5
Compare
|
@fpetkovski I also add this change to the changelog, so users will inform about this new behavior. |
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
May 18, 2023
As SyncMetas is surrounded by Repeat func and can return retry errors, in some cases (like S3) errors (network issue, timeout, etc.) can be retried. Signed-off-by: Seena Fallah <seenafallah@gmail.com> Signed-off-by: Seena Fallah <seenafallah@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
As SyncMetas is surrounded by Repeat func and can return retry errors, in some cases (like S3) errors (network issue, timeout, etc.) can be retried.
Signed-off-by: Seena Fallah seenafallah@gmail.com
Verification
Currently in case of any errs on
SyncMetasit will gracefully shutdown the HTTP server, It can be verified by e.g. issuing timeout on SyncMetas func