Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets the default sd-dns-resolver for ruler miekgdns #5997

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Sets the default sd-dns-resolver for ruler miekgdns #5997

merged 1 commit into from
Dec 23, 2022

Conversation

JoaoBraveCoding
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Related to issue: #4204

Problem: in the PR #4519 the default sd-dns-resolver for querier was set to miekgdns but this change was never ported to ruler

Solution: this PR brings this default to ruler as well to make it consistent

Related to issue: #4204

Problem: in the PR #4519 the
default sd-dns-resolver for querier was set to miekgdns but this change
was never ported to ruler

Solution: this PR brings this default to ruler as well to make it
consistent

Signed-off-by: JoaoBraveCoding <jmarcal@redhat.com>
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@squat squat merged commit c4a1b91 into thanos-io:main Dec 23, 2022
ngraham20 pushed a commit to ngraham20/thanos that referenced this pull request Apr 17, 2023
Related to issue: thanos-io#4204

Problem: in the PR thanos-io#4519 the
default sd-dns-resolver for querier was set to miekgdns but this change
was never ported to ruler

Solution: this PR brings this default to ruler as well to make it
consistent

Signed-off-by: JoaoBraveCoding <jmarcal@redhat.com>

Signed-off-by: JoaoBraveCoding <jmarcal@redhat.com>
ngraham20 pushed a commit to ngraham20/thanos that referenced this pull request Apr 17, 2023
Related to issue: thanos-io#4204

Problem: in the PR thanos-io#4519 the
default sd-dns-resolver for querier was set to miekgdns but this change
was never ported to ruler

Solution: this PR brings this default to ruler as well to make it
consistent

Signed-off-by: JoaoBraveCoding <jmarcal@redhat.com>

Signed-off-by: JoaoBraveCoding <jmarcal@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants