Store: Make bucket store initial sync more robust #6050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kartik-Garg
force-pushed
the
store-initial-sync-robust
branch
7 times, most recently
from
cc05e2d
to
e85223b
Compare
Kartik-Garg
force-pushed
the
store-initial-sync-robust
branch
from
0b5a1d4
to
7cf7292
Compare
Kartik-Garg
force-pushed
the
store-initial-sync-robust
branch
9 times, most recently
from
455524f
to
e20ef21
Compare
Kartik-Garg
changed the title
Kartik-Garg
changed the title
Kartik-Garg
force-pushed
the
store-initial-sync-robust
branch
6 times, most recently
from
9736806
to
94d249b
Compare
|
@matej-g could someone from team please review this PR? :) |
Kartik-Garg
force-pushed
the
store-initial-sync-robust
branch
from
ebede3f
to
589767f
Compare
Kartik-Garg
force-pushed
the
store-initial-sync-robust
branch
4 times, most recently
from
4a56ae0
to
4eed912
Compare
fpetkovski
reviewed
Jan 24, 2023
Kartik-Garg
force-pushed
the
store-initial-sync-robust
branch
from
4eed912
to
b56a3c0
Compare
@fpetkovski , thanks for the suggestions, I have made the changes accordingly :) |
Kartik-Garg
force-pushed
the
store-initial-sync-robust
branch
3 times, most recently
from
dc58870
to
a5972ea
Compare
matej-g
reviewed
Jan 25, 2023
Added re-try mechanism for store inital sync, where if the initial sync fails, it tries to do the initial sync again for given timeout duration. Signed-off-by: Kartik-Garg <kartik.garg@infracloud.io>
Kartik-Garg
force-pushed
the
store-initial-sync-robust
branch
from
a5972ea
to
720f608
Compare
Kartik-Garg
requested review from
matej-g and
fpetkovski
and removed request for
matej-g and
fpetkovski
matej-g
approved these changes
Jan 26, 2023
@matej-g thanks a lot for approving it, this is going to be my first open source PR (non document related) 🎉. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #4810
Signed-off-by: Kartik-Garg kartik.garg@infracloud.io
Changes
This PR implements the change: If the initial sync fails for the store, it will retry the initialization using runutil.retry with default values, it retries to initialize the store every 10 seconds for 30 duration of seconds, i.e., total of three times
Verification
After starting the local minio server, started store component (quickstart gist, edited from quickstart.sh)
Store retried sync and succeeded with initial sync