Support native histograms in store-gateway #6056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
fpetkovski
force-pushed
the
store-gw-histograms
branch
2 times, most recently
from
2f858cb
to
1f8f571
Compare
|
This is currently blocked by #6032. |
fpetkovski
force-pushed
the
store-gw-histograms
branch
from
1f8f571
to
f73fdb0
Compare
fpetkovski
force-pushed
the
store-gw-histograms
branch
from
05cb998
to
3c1ab8d
Compare
This commit adds support for retrieving native histogram chunks in Store Gateway. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
fpetkovski
force-pushed
the
store-gw-histograms
branch
from
3c1ab8d
to
0222886
Compare
fpetkovski
force-pushed
the
store-gw-histograms
branch
from
0222886
to
edad214
Compare
|
Should be ready for review now. |
GiedriusS
reviewed
Feb 20, 2023
GiedriusS
reviewed
Feb 20, 2023
GiedriusS
reviewed
Feb 20, 2023
GiedriusS
reviewed
Feb 20, 2023
GiedriusS
reviewed
Feb 20, 2023
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
GiedriusS
approved these changes
Feb 20, 2023
|
Hm I am not sure if the sonatype-lift comments make sense. Two of them say it cannot import |
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
* Support native histograms in store-gateway This commit adds support for retrieving native histogram chunks in Store Gateway. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Fix tests Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Revert test changes Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
* Support native histograms in store-gateway This commit adds support for retrieving native histogram chunks in Store Gateway. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Fix tests Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Revert test changes Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for retrieving native histogram chunks
in Store Gateway.
Changes
Verification