Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use non root user as default user in container image #6107

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

timo-42
Copy link
Contributor

@timo-42 timo-42 commented Feb 7, 2023

Signed-off-by: Timo Haas haastimo@gmx.de

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Changed default user in container images from 0 to 1001

Verification

Tested thanos-query in k8s cluster

Dockerfile Show resolved Hide resolved
Signed-off-by: Timo Haas <haastimo@gmx.de>
@matej-g matej-g enabled auto-merge (squash) March 17, 2023 11:15
@matej-g
Copy link
Collaborator

matej-g commented Mar 17, 2023

Thank you @timo-42!

@matej-g matej-g merged commit 143c49a into thanos-io:main Mar 17, 2023
richardtief added a commit to sapcc/helm-charts that referenced this pull request Jan 4, 2024
The upstream Thanos image has changed the default user in the container image to 1001 instead of 0 (root).

thanos-io/thanos#6107

As we are dependent on user 0 in our environment, we explicitly set it to 0.
viennaa pushed a commit to sapcc/helm-charts that referenced this pull request Jan 4, 2024
The upstream Thanos image has changed the default user in the container image to 1001 instead of 0 (root).

thanos-io/thanos#6107

As we are dependent on user 0 in our environment, we explicitly set it to 0.
@WyrickC
Copy link

WyrickC commented Apr 18, 2024

Hi, just wondering why this change was made? We have our thanos compactor running as any UID and this change is breaking for us. We can get it to work in our K8s cluster by making sure it runs as root, but we'd rather not have it do that. Any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants