Deduplicate metamonitoring queries #6121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves #6120 |
1 similar comment
|
Resolves #6120 |
yeya24
reviewed
Feb 13, 2023
| @@ -31,7 +31,7 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re | |||
| - [#6082](https://github.com/thanos-io/thanos/pull/6082) Store: Don't error when no stores are matched. | |||
| - [#6098](https://github.com/thanos-io/thanos/pull/6098) Cache/Redis: upgrade `rueidis` to v0.0.93 to fix potential panic when the client-side caching is disabled. | |||
| - [#6103](https://github.com/thanos-io/thanos/pull/6103) Mixins(Rule): Fix query for long rule evaluations. | |||
|
|
|||
| - [#6121](https://github.com/thanos-io/thanos/pull/6121) Receive: Deduplicate metamonitoring queries. | |||
There was a problem hiding this comment.
Please keep an empty line to the next section.
Signed-off-by: Andre Baptista Aguas <andre.aguas@protonmail.com> Signed-off-by: Andre Baptista Aguas <andre.agua@protonmail.com>
Signed-off-by: Andre Baptista Aguas <andre.aguas@protonmail.com> Signed-off-by: Andre Baptista Aguas <andre.agua@protonmail.com>
Signed-off-by: Andre Baptista Aguas <andre.agua@protonmail.com>
fpetkovski
approved these changes
Feb 14, 2023
|
Thanks for fixing! 🎉 |
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
* Deduplicate metamonitoring queries Signed-off-by: Andre Baptista Aguas <andre.aguas@protonmail.com> Signed-off-by: Andre Baptista Aguas <andre.agua@protonmail.com> * Update CHANGELOG Signed-off-by: Andre Baptista Aguas <andre.aguas@protonmail.com> Signed-off-by: Andre Baptista Aguas <andre.agua@protonmail.com> * do not remove empty line from CHANGELOG Signed-off-by: Andre Baptista Aguas <andre.agua@protonmail.com> --------- Signed-off-by: Andre Baptista Aguas <andre.aguas@protonmail.com> Signed-off-by: Andre Baptista Aguas <andre.agua@protonmail.com> Co-authored-by: Andre Baptista Aguas <andre.agua@protonmail.com>
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
* Deduplicate metamonitoring queries Signed-off-by: Andre Baptista Aguas <andre.aguas@protonmail.com> Signed-off-by: Andre Baptista Aguas <andre.agua@protonmail.com> * Update CHANGELOG Signed-off-by: Andre Baptista Aguas <andre.aguas@protonmail.com> Signed-off-by: Andre Baptista Aguas <andre.agua@protonmail.com> * do not remove empty line from CHANGELOG Signed-off-by: Andre Baptista Aguas <andre.agua@protonmail.com> --------- Signed-off-by: Andre Baptista Aguas <andre.aguas@protonmail.com> Signed-off-by: Andre Baptista Aguas <andre.agua@protonmail.com> Co-authored-by: Andre Baptista Aguas <andre.agua@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andre Baptista Aguas andre.aguas@protonmail.com
Changes
Add the
Deduplicate: trueoption to metamonitoring queries. The default value wasfalseVerification
Ran the binary in receive mode and confirmed that query results are deduplicated.