receive: fail early if ketama hashring is configured with number of nodes lower than the replication factor #6168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaHoffmann
force-pushed
the
mhoffm-fail-ketama-hashring-early
branch
from
de099b6
to
5bb16dc
Compare
matej-g
reviewed
Feb 27, 2023
There was a problem hiding this comment.
Thanks @MichaHoffmann, this is looking nice!
I'm not sure why CircleCI is on strike again, I often see the run fails for first-time contributors, I'll try to see if we can fix it.
MichaHoffmann
force-pushed
the
mhoffm-fail-ketama-hashring-early
branch
from
5bb16dc
to
3f4491d
Compare
MichaHoffmann
changed the title
fpetkovski
reviewed
Feb 28, 2023
| @@ -576,7 +579,10 @@ func testReceiveQuorum(t *testing.T, hashringAlgo HashringAlgorithm, withConsist | |||
| }, | |||
| } { | |||
| t.Run(tc.name, func(t *testing.T) { | |||
| handlers, hashring := newTestHandlerHashring(tc.appendables, tc.replicationFactor, hashringAlgo) | |||
| handlers, hashring, err := newTestHandlerHashring(tc.appendables, tc.replicationFactor, hashringAlgo) | |||
| if err != nil { | |||
There was a problem hiding this comment.
We usually use testutil.Ok.
There was a problem hiding this comment.
I chose that to be consistent with the other assertions in this test. Its probably best to update all of them. While i'm at it should i also convert them to testutil.Ok form?
There was a problem hiding this comment.
I think that's a good point, let's then leave it as it is for consistency.
MichaHoffmann
force-pushed
the
mhoffm-fail-ketama-hashring-early
branch
from
a079830
to
36740b6
Compare
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
MichaHoffmann
force-pushed
the
mhoffm-fail-ketama-hashring-early
branch
from
7fbb9f6
to
75cc464
Compare
matej-g
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5639
Changes
Construction of the ketama hashring can busyloop forever if less endpoints than replication factor was configured even briefly.
Verification
Added a unittest.