Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tracing] tracing in OTLP support configuring service_name #6185

Merged
merged 3 commits into from
Mar 7, 2023
Merged

[tracing] tracing in OTLP support configuring service_name #6185

merged 3 commits into from
Mar 7, 2023

Conversation

fatsheep9146
Copy link
Contributor

@fatsheep9146 fatsheep9146 commented Mar 6, 2023 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

fix #6184

add service_name to OTLP tracing config to improve the readiness of the trace data.

image

@fatsheep9146
tracing in OTLP support configuring service_name
ff35acd 
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
yeya24
yeya24 reviewed Mar 6, 2023
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fix makes sense to me.

I have retried the Docs CI and let us make sure this change won't need any other doc change.

@saswatamcode
Copy link
Member

Looks like this adds a field to the config. Can you run make docs @fatsheep9146?

@fatsheep9146
make docs
a9c1841 
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
@fatsheep9146
Copy link
Contributor Author

Looks like this adds a field to the config. Can you run make docs @fatsheep9146?

Done @saswatamcode

saswatamcode
saswatamcode previously approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

yeya24
yeya24 reviewed Mar 6, 2023
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change lgtm. Can you update the changelog please?

@fatsheep9146
add changelog
4c5e631 
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
@fatsheep9146
Copy link
Contributor Author

Change lgtm. Can you update the changelog please?

I directly changed the CHANGELOG.md. :)
@yeya24

@saswatamcode saswatamcode enabled auto-merge (squash) March 6, 2023 07:33
@saswatamcode saswatamcode merged commit 7313a2c into thanos-io:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeya24 yeya24 yeya24 approved these changes

@saswatamcode saswatamcode saswatamcode left review comments

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tracing in OTLP support configuring service_name
3 participants
@fatsheep9146 @saswatamcode @yeya24