store: add flag to select the label to use as timeline title in web UI #6192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thib-ack
force-pushed
the
store-bucket-web-label
branch
2 times, most recently
from
dca5c6e
to
3d9122c
Compare
fpetkovski
previously approved these changes
Mar 7, 2023
cmd/thanos/store.go
Outdated
| @@ -183,6 +184,8 @@ func (sc *storeConfig) registerFlag(cmd extkingpin.FlagClause) { | |||
| cmd.Flag("web.disable-cors", "Whether to disable CORS headers to be set by Thanos. By default Thanos sets CORS headers to be allowed by all."). | |||
| Default("false").BoolVar(&sc.webConfig.disableCORS) | |||
|
|
|||
| cmd.Flag("bucket-web-label", "Prometheus label to use as timeline title in the bucket web UI").StringVar(&sc.label) | |||
There was a problem hiding this comment.
Suggested change
| cmd.Flag("bucket-web-label", "Prometheus label to use as timeline title in the bucket web UI").StringVar(&sc.label) | |
| cmd.Flag("bucket-web-label", "External block label to use as group title in the bucket web UI").StringVar(&sc.label) |
There was a problem hiding this comment.
Thanks,
I fixed the wording in store, compact and tools_bucket
Signed-off-by: Thibaut Ackermann <thibaut.ackermann@al-enterprise.com>
thib-ack
force-pushed
the
store-bucket-web-label
branch
from
3d9122c
to
7e31886
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Compactorhas this nice flag--bucket-web-labelto select the label to use as timeline title in the 'block' web UI (i.e. replace the1value in the following screenshot with a comprehensible value) :However,
Storeis missing this flag, so I added it, using the same name/description to stay consistent.Changes
--bucket-web-labeltostorecommandVerification