Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Update busybox versions and cron #6237

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

matej-g
Copy link
Collaborator

@matej-g matej-g commented Mar 22, 2023

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Manually update busybox versions.

Also make the cronjob more frequent (every hour), since in case of change we might have to wait up to a day before we catch the change, causing CI failures etc.

Signed-off-by: Matej Gera <matej.gera@coralogix.com>
@douglascamata
Copy link
Contributor

@matej-g I would like to challenge this "automated manual" update of the https://quay.io/prometheus/busybox image tags. I did some quick investigation in the Prometheus repo and they don't have a similar flow.

Do we have a good reason for doing this in Thanos? Was there ever an issue which this flow solved?

@jacobbaungard
Copy link
Contributor

@matej-g I would like to challenge this "automated manual" update of the https://quay.io/prometheus/busybox image tags. I did some quick investigation in the Prometheus repo and they don't have a similar flow.

Do we have a good reason for doing this in Thanos? Was there ever an issue which this flow solved?

It breaks e2e tests as the old images tags seems to be removed, see for example the failures here: #6228

@douglascamata
Copy link
Contributor

@jacobbaungard if we used the latest tag, like Prometheus uses in their own repo, we wouldn't have this issue. My point is: why aren't we using latest to avoid the need for this automation and the temporary problems it causes?

@fpetkovski
Copy link
Contributor

Hm seems like we're blocked on #6236 as well.

@matej-g
Copy link
Collaborator Author

matej-g commented Mar 22, 2023

@douglascamata can we first fix current way, so at least all pending PRs (and release) are unblocked? If you'd like to learn more about the history of the issue, feel free to take a look at #4949.

@douglascamata
Copy link
Contributor

@matej-g 100%. Let's unblock all the PRs 🚀

@douglascamata
Copy link
Contributor

@matej-g @fpetkovski shall we merge this? 🙏

@fpetkovski
Copy link
Contributor

And so it shall be merged 🚢

@fpetkovski fpetkovski merged commit 553b8d7 into thanos-io:main Mar 22, 2023
@douglascamata
Copy link
Contributor

Thanks, everyone! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants