Vertical shard binary expression using metric name when no matching label #6605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
force-pushed
the
vertical-sharding-binaaryexpr
branch
2 times, most recently
from
912244c
to
aab0392
Compare
3 tasks
GiedriusS
previously approved these changes
Aug 16, 2023
fpetkovski
previously approved these changes
Aug 16, 2023
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
yeya24
force-pushed
the
vertical-sharding-binaaryexpr
branch
from
87e0de6
to
936236a
Compare
|
I enabled merge on green since it was approved already and fixed conflict. |
|
I will go ahead and merge the pr as it was approved before and doc failed unrelated |
harsh-ps-2003
pushed a commit
to harsh-ps-2003/thanos
that referenced
this pull request
Aug 22, 2023
…abel (thanos-io#6605) * vertically shard binary expression even if no matching labels Signed-off-by: Ben Ye <benye@amazon.com> * add changelog Signed-off-by: Ben Ye <benye@amazon.com> * fix test Signed-off-by: Ben Ye <benye@amazon.com> --------- Signed-off-by: Ben Ye <benye@amazon.com>
coleenquadros
pushed a commit
to coleenquadros/thanos
that referenced
this pull request
Sep 18, 2023
…abel (thanos-io#6605) * vertically shard binary expression even if no matching labels Signed-off-by: Ben Ye <benye@amazon.com> * add changelog Signed-off-by: Ben Ye <benye@amazon.com> * fix test Signed-off-by: Ben Ye <benye@amazon.com> --------- Signed-off-by: Ben Ye <benye@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Binary expression can be vertically sharded without
__name__label if no matching labels are specified.Image we have two series
A query
foo - baris basically a join offooandbarseries. The join will ignore the metric name and will calculate hash for the rest labels in this case.Verification