Improve index header metrics #6847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harry671003
changed the title
yeya24
reviewed
Oct 26, 2023
pkg/store/bucket.go
Outdated
| @@ -189,9 +189,8 @@ func newBucketStoreMetrics(reg prometheus.Registerer) *bucketStoreMetrics { | |||
| m.blockLoadDuration = promauto.With(reg).NewHistogram(prometheus.HistogramOpts{ | |||
| Name: "thanos_bucket_store_block_load_duration_seconds", | |||
| Help: "The total time taken to load a block in seconds.", | |||
| Buckets: []float64{0.1, 0.5, 1, 10, 20, 30, 60, 120}, | |||
| Buckets: []float64{0.01, 0.02, 0.05, 0.1, 0.2, 0.5, 1, 2, 5, 15, 30, 60, 90, 120, 300}, | |||
There was a problem hiding this comment.
I am thinking about maybe we can start from a larger number like 1s instead of having multiple small buckets from 0.01 to 0.5.
WDYT? I feel like we don't care much about loading blocks fast. For example, we load block from disk cache.
There was a problem hiding this comment.
Same might apply to other two metrics you added
There was a problem hiding this comment.
I agree. At least for the thanos_bucket_store_block_load_duration_seconds and the indexheader_download_duration_seconds, it may not be reasonable to expect it to take less than 100ms.
But the indexheader_load_duration_seconds should take much less right? I'll keep the smaller buckets on that metric.
yeya24
reviewed
Oct 26, 2023
Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
harry671003
force-pushed
the
index-header-metrics
branch
from
9407534
to
43bf29c
Compare
|
Need to sign off DCO |
Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
harry671003
force-pushed
the
index-header-metrics
branch
from
43bf29c
to
bd3c472
Compare
douglascamata
pushed a commit
to douglascamata/thanos
that referenced
this pull request
Dec 13, 2023
* Improve binary reader metrics Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com> * Update buckets Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com> * Update CHANGELOG Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com> --------- Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
douglascamata
pushed a commit
to douglascamata/thanos
that referenced
this pull request
Dec 13, 2023
* Improve binary reader metrics Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com> * Update buckets Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com> * Update CHANGELOG Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com> --------- Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
thanos_bucket_store_block_load_duration_secondsmetrics.indexheader_download_duration_secondsfor tracking how long it takes to download the indexheader from objstore.indexheader_load_duration_secondsto track how long it takes to initialize the binary reader.