Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query: fixing dedup iterator when working on mixed sample types #7271

Merged
merged 10 commits into from
Apr 11, 2024
Merged

query: fixing dedup iterator when working on mixed sample types #7271

merged 10 commits into from
Apr 11, 2024

Commits on Apr 10, 2024

  1. query: fixing dedup iterator when working on mixed sample types 

    There was a panic in case the dedupiterator worked on two chunks with both Native Histograms and Float (XOR encoded).

Co-authored-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
    @pedro-stanaka @rabenhorst
    pedro-stanaka and rabenhorst committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    d2c0f87 View commit details
    Browse the repository at this point in the history

  2. Adding changelog 

    Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
    @pedro-stanaka
    pedro-stanaka committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    1f96bc7 View commit details
    Browse the repository at this point in the history

  3. fixing lint 

    Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
    @pedro-stanaka
    pedro-stanaka committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    58bd8e4 View commit details
    Browse the repository at this point in the history

  4. removing comments 

    Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
    @pedro-stanaka
    pedro-stanaka committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    b2af937 View commit details
    Browse the repository at this point in the history

  5. Fixing repro test case 

    Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
    @pedro-stanaka
    pedro-stanaka committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    fa657b0 View commit details
    Browse the repository at this point in the history

  6. fixing initialization 

    Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
    @pedro-stanaka
    pedro-stanaka committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    ab737ff View commit details
    Browse the repository at this point in the history

  7. fixing changelog 

    Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
    @pedro-stanaka
    pedro-stanaka committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    40b1030 View commit details
    Browse the repository at this point in the history

  8. adding header to new file 

    Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
    @pedro-stanaka
    pedro-stanaka committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    e1c3e79 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. using t.Run 

    Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
    @pedro-stanaka
    pedro-stanaka committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    3296210 View commit details
    Browse the repository at this point in the history

  2. fixing ordering of samples in tests 

    Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
    @pedro-stanaka
    pedro-stanaka committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    0a6a908 View commit details
    Browse the repository at this point in the history