Use cached label sets #7420
Merged
Use cached label sets #7420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The distributed engine retrieves label sets once per query, and doing the expensive copying and conversion uses a lot of memory. We already set them in the format we need in the endpoint status, so we can retrieve them from there. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
fpetkovski
force-pushed
the
cached-labelsets
branch
from
614481f
to
07e46fa
Compare
MichaHoffmann
approved these changes
Jun 9, 2024
hczhu-db
pushed a commit
to databricks/thanos
that referenced
this pull request
Aug 22, 2024
The distributed engine retrieves label sets once per query, and doing the expensive copying and conversion uses a lot of memory. We already set them in the format we need in the endpoint status, so we can retrieve them from there. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
hczhu-db
pushed a commit
to databricks/thanos
that referenced
this pull request
Aug 22, 2024
The distributed engine retrieves label sets once per query, and doing the expensive copying and conversion uses a lot of memory. We already set them in the format we need in the endpoint status, so we can retrieve them from there. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The distributed engine retrieves label sets once per query, and doing the expensive copying and conversion uses a lot of memory.
We already set them in the format we need in the endpoint status, so we can retrieve them from there.
Changes
Verification