Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy: fix response set panic #7484

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

MichaHoffmann
Copy link
Contributor

@MichaHoffmann MichaHoffmann commented Jun 25, 2024

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Adding the error tag panics in my prod with a nil pointer dereference. We can reach this if the error we face is not a context exceeded error but the timer has expired. I think we also forgot to receive from the timer channel in the lazy response set.

Verification

Existing tests.

Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
@SuperQ
Copy link
Contributor

SuperQ commented Jun 25, 2024

CC @wallee94

Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@MichaHoffmann MichaHoffmann merged commit 9a96e34 into main Jun 26, 2024
20 checks passed
hczhu-db pushed a commit to databricks/thanos that referenced this pull request Aug 22, 2024
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
hczhu-db pushed a commit to databricks/thanos that referenced this pull request Aug 22, 2024
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants