Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Receive: fix thanos_receive_write_{timeseries,samples} stats #7643

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Receive: fix thanos_receive_write_{timeseries,samples} stats #7643

merged 2 commits into from
Sep 3, 2024

Commits on Sep 3, 2024

  1. Revert "Receive: fix stats (thanos-io#7373)" 

    This reverts commit 66841fb.

Signed-off-by: Mikhail Nozdrachev <mikhail.nozdrachev@aiven.io>
    @cincinnat
    cincinnat committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    cb67b9e View commit details
    Browse the repository at this point in the history

  2. Receive: fix thanos_receive_write_{timeseries,samples} stats 

    There are two path data can be written to a receiver: through the HTTP
or the gRPC endpoint, and `thanos_receive_write_{timeseries,samples}` only
count the number of timeseries/samples received through the HTTP
endpoint.

So, there is no risk that a sample will be counted twice, once as a
remote write and once as a local write. On the other hand, we still need
to account for the replication factor, and only count local writes is
not enough as there might be no local writes at all (e.g. in RouterOnly
mode).

Signed-off-by: Mikhail Nozdrachev <mikhail.nozdrachev@aiven.io>
    @cincinnat
    cincinnat committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    dbc840a View commit details
    Browse the repository at this point in the history