Store: Fix panic too smaller buffer

[dominicqi]

• I added CHANGELOG entry for this change.
• Change is not relevant to the end user.

Changes

Related issue #6934
I think the problem could be: a buffer that was not obtained from the buffer pool should not be put back into it, as it will lead to buffers with incorrect sizes.

[saswatamcode]

Could you sign this commit?

[dominicqi]

Could you sign this commit?

@saswatamcode signed, but the e2e test failed , i can't see error information

[GiedriusS]

Could you add a unit test for this?

[dominicqi]

Could you add a unit test for this?

Hi, @GiedriusS i haven't thought of what unit tests should be added yet. What do you think should be added? just moved the defer statement to the appropriate place.

[GiedriusS]

Could you add a unit test for this?

Hi, @GiedriusS i haven't thought of what unit tests should be added yet. What do you think should be added? just moved the defer statement to the appropriate place.

I think a test should call that function twice and in the second call it should get a wrongly sized buffer with this bug, right?

[dominicqi]

Could you add a unit test for this?

Hi, @GiedriusS i haven't thought of what unit tests should be added yet. What do you think should be added? just moved the defer statement to the appropriate place.

I think a test should call that function twice and in the second call it should get a wrongly sized buffer with this bug, right?

I don't think so; the buffer pool returns a wrongly sized buffer because it has a smaller buffer. Just make sure only the obtained buffer can return to the pool.

[yeya24]

I think a unit test is still good to have to catch such regression next time.

[dominicqi]

I think a unit test is still good to have to catch such regression next time.

[yeya24]

I will get this merged to fix the bug. Thanks @dominicqi.