Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store: added a log error print when proxy limit are violated #7683

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

tizki
Copy link
Contributor

@tizki tizki commented Sep 2, 2024

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

I added a log error when there are violations of the store's proxy limits.

Verification

Tested locally and verified the message is printed to the log.

Signed-off-by: Tidhar Klein Orbach <tidhar.o@taboola.com>
@tizki tizki force-pushed the log-errors-on-limiter-violations branch from b5d6056 to 5c5c36d Compare September 2, 2024 10:41
pkg/store/proxy.go Outdated Show resolved Hide resolved
Co-authored-by: Pedro Tanaka <pedro.tanaka@shopify.com>
Signed-off-by: Tidhar Klein Orbach <tizki@users.noreply.github.com>
@MichaHoffmann MichaHoffmann merged commit cbf4fb4 into thanos-io:main Sep 13, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants