Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store: Add acceptance tests for limit #7739

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Store: Add acceptance tests for limit #7739

wants to merge 1 commit into from

Conversation

harry671003
Copy link
Contributor

@harry671003 harry671003 commented Sep 13, 2024 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

@harry671003
Store: Add acceptance tests for limit
639b658 
Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
MichaHoffmann
MichaHoffmann approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@MichaHoffmann MichaHoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests themselves look good, do we need to bump Prometheus?

@harry671003
Copy link
Contributor Author

harry671003 commented Sep 13, 2024 •
edited
Loading

The tests themselves look good, do we need to bump Prometheus?

@MichaHoffmann - I have opened a couple of PRs in Prometheus to implement the limit param in mergeQuerier and blockQuerier.

I'm currently waiting for those to be merged before bumping Prometheus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaHoffmann MichaHoffmann MichaHoffmann approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harry671003 @MichaHoffmann