Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store: don't create intermediate labels #7762

Merged
merged 1 commit into from
Sep 19, 2024
Merged

store: don't create intermediate labels #7762

merged 1 commit into from
Sep 19, 2024
+29 −1

Conversation

GiedriusS
Copy link
Member

Just compare labelpb.Label directly instead of creating promlabels from them.

@GiedriusS
store: don't create intermediate labels
5f66bfb 
Just compare labelpb.Label directly instead of creating promlabels from
them.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
@GiedriusS GiedriusS force-pushed the dont_create_intermediate_labels branch from 164a92f to 5f66bfb Compare September 19, 2024 14:10
@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 19, 2024
@GiedriusS GiedriusS marked this pull request as ready for review September 19, 2024 14:15
fpetkovski
fpetkovski approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@fpetkovski fpetkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can do something similar for Series calls so that we can marshal prometheus labels directly to the proto wire format.

@GiedriusS GiedriusS merged commit 8cd3fae into main Sep 19, 2024
21 of 22 checks passed
@GiedriusS GiedriusS deleted the dont_create_intermediate_labels branch September 19, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpetkovski fpetkovski fpetkovski approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GiedriusS @fpetkovski