Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule component: Adding new API end point for rules and alerts in #851

Merged
merged 6 commits into from
Mar 4, 2019

Conversation

davtsur
Copy link
Contributor

@davtsur davtsur commented Feb 17, 2019

Adding 2 new API end points for the rule component :

  1. "api/vi/rules"
  2. "api/vi/alerts"

Changes

  1. Added 2 end points (based on prometheus rules end point)
  2. Changed a few functions in the query API to be accessible and reused them in a new rule API class.
    Its also an option to add a common class for shared code of rule and query components, but I wasn't sure this is necessary.

Verification

  1. Tested query and rule components locally
  2. Added unitest for rule/alerts end points

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could put it in single v1 package for ease of use... But that's fine for now, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants