Updated changelog to make sure the important change with index-cache-size is known. #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
requested changes
Mar 12, 2019
CHANGELOG.md
Outdated
| - [#873](https://github.com/improbable-eng/thanos/pull/873) Store: fix set index cache LRU | ||
|
|
||
| :warning: **WARING** :warning: #873 fix fixes actual handling of `index-cache-size`. Handling of limit for this cache was | ||
| broken so it was unbounded all the time. From this release actual value matters and is extremely low by default. To make "revert" |
There was a problem hiding this comment.
make doesn't seem in place here
CHANGELOG.md
Outdated
|
|
||
| :warning: **WARING** :warning: #873 fix fixes actual handling of `index-cache-size`. Handling of limit for this cache was | ||
| broken so it was unbounded all the time. From this release actual value matters and is extremely low by default. To make "revert" | ||
| the old behaviour (no boundary), but here large enough value. |
There was a problem hiding this comment.
put here a large enough value
improbable-ludwik
approved these changes
Mar 12, 2019
CHANGELOG.md
Outdated
|
|
||
| :warning: **WARING** :warning: #873 fix fixes actual handling of `index-cache-size`. Handling of limit for this cache was | ||
| broken so it was unbounded all the time. From this release actual value matters and is extremely low by default. To "revert" | ||
| the old behaviour (no boundary), put here a large enough value. |
There was a problem hiding this comment.
nit: put here a large enough value. -> use a large enough value.
…size is known. Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
earthdiaosi
pushed a commit
to earthdiaosi/thanos
that referenced
this pull request
Mar 14, 2019
…size is known. (thanos-io#913) Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.