Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Add possibility to inline ServiceAccount into GCS config #963

Merged
merged 3 commits into from
Mar 26, 2019

Conversation

metalmatze
Copy link
Contributor

Changes

Add service_account as multi line string to GCS config.

Verification

I've tested that the binary locally starts without any connections errors.

We need this change so that we can have one unified way of configuring the Thanos object storage. Additionally it will make the Prometheus Operator's life easier to manage those components (sidecar).

/cc @bwplotka @brancz @s-urbaniak

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, with suggesitons.

pkg/objstore/gcs/gcs.go Outdated Show resolved Hide resolved
opts = append(opts, option.WithCredentials(credentials))
}

opts = append(opts,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a side thing (not a blocker for this PR), can we unsure, "debug" name from debug.name flag is passed here? for component for example? It would help if use agent would be actually some name you configured I guess?

Co-Authored-By: metalmatze <mail@matthiasloibl.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants