store/proxy: set {Min,Max}Time accordingly to the nodes #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't make sense to advertise that a Thanos Query node has data since the beginning of the time and till the end of time if it only has nodes which have specific time ranges of data. Change it accordingly by checking each time range of each node and setting it to the min/max values.
povilasv
approved these changes
Mar 28, 2019
|
But we need to fix the tests (: and make it a non-draft PR |
|
Yes yes, I will do that once I will have some more spare time :P |
In case there are no configured stores at Thanos Query we want to revert to the old behaviour and inform the Info() callers that indeed we do have all of the data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense to advertise that a Thanos Query node has data
since the beginning of the time and till the end of time if it only has
nodes which have specific time ranges of data.
Change it accordingly by checking each time range of each node and
setting it to the min/max values.
Calling these functions is fine as the values are cached and
TimeRange()functions are protected by mutexes.