Add webhooks CLI plugin #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Jul 23, 2021
There was a problem hiding this comment.
Coudld you have matching timestamps for the migrations? https://github.com/theforeman/foreman-installer/blob/develop/bin/create-migration is a helper that makes it easy. You can even input the migration on STDIN.
ofedoren
force-pushed
the
add-webhooks-cli
branch
from
b3c3e33
to
ce1c20f
Compare
|
@ekohl, I've created those migrations via this exact script, I guess I didn't notice that multiple directories can be used... Thanks, updated. |
|
[test foreman-installer] |
1 similar comment
|
[test foreman-installer] |
|
I think you may need to rebase now. |
ofedoren
force-pushed
the
add-webhooks-cli
branch
from
ce1c20f
to
13a5316
Compare
|
Thanks, done. |
|
@ekohl should I open a CP PR? |
|
We'll need a cherry pick of puppet-foreman as well for that. It would have been easier to have a Redmine issue for that so we wouldn't lose track of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to theforeman/puppet-foreman#977.
Also needs to be CPed into 2.5.