-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hammer-cli-foreman-host-reports #7620
Add hammer-cli-foreman-host-reports #7620
Conversation
[test deb] |
1 similar comment
[test deb] |
Vcs-Git: https://salsa.debian.org/ruby-team/ruby-hammer-cli-foreman-host-reports.git | ||
Vcs-Browser: https://salsa.debian.org/ruby-team/ruby-hammer-cli-foreman-host-reports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't true, so let's not set those options :)
Maintainer: Debian Ruby Extras Maintainers <pkg-ruby-extras-maintainers@lists.alioth.debian.org> | ||
Uploaders: <> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't true, as this package is not in debian, please set to yourself, or some generic foreman address.
@@ -0,0 +1,4 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can drop this file, it;s unused in our case
tests fail with |
b6786ee
to
7f90e0d
Compare
Well, my assumption was that since it's required in test files only and this gem is installed with hammer-cli-foreman's Gemfile (https://github.com/theforeman/hammer-cli-foreman/blob/master/Gemfile#L11) I could simply require it in h-c-f-host-reports as well. Please don't tell me that now I need to update Gemfile/gemspec and release a new version just because of this... |
That I didn't say. The packaging of |
@@ -0,0 +1,6 @@ | |||
require 'gem2deb/rake/testtask' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you try dropping this file and see what happens? I think that's the one that executes the tests for us.
7f90e0d
to
966d438
Compare
ok to test |
Maintainer: Oleh Fedorenko <ofedoren@redhat.com> | ||
Uploaders: <> | ||
Build-Depends: debhelper-compat (= 12), | ||
gem2deb (>= 1), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gem2deb (>= 1), | |
gem2deb, |
we don't need >=1 and it's not available in buster
Section: ruby | ||
Priority: optional | ||
Maintainer: Oleh Fedorenko <ofedoren@redhat.com> | ||
Uploaders: <> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uploaders: <> |
@@ -0,0 +1,9 @@ | |||
--- | |||
Archive: GitHub (FIXME) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the FIXME part here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea what this file is, anyways ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://wiki.debian.org/UpstreamMetadata#Fields doesn't tell much and I didn't find an example there :(
966d438
to
75ab740
Compare
@evgeni, all seems to be OK now :) |
Supported Versions: