-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #37566 - Add UEFI Secure Boot Firmware to Libvirt #10321
base: develop
Are you sure you want to change the base?
Conversation
Failing tests should be fixed automatically after fog/fog-libvirt#155 is merged. |
- Added a new firmware type for Secure Boot. - Enable `enrolled-keys` by default when Secure Boot is activated. - Added firmware-related methods to the ComputeResource model for shared use between VMware and Libvirt.
As noted in my comment on the VMware-related PR #10324 (comment), the same issue occurs with Libvirt. The |
:port => '-1' } | ||
:port => '-1' }, | ||
:firmware => 'automatic', | ||
:firmware_features => { "secure-boot" => "no" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for having strings as keys in the inner hash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires:
This PR includes two commits:
When creating a new host in Foreman, after selecting
Libvirt
as the compute resource, a new option to select the VM's firmware will appear under theVirtual Machine
tab. See the screenshot below for a demonstration:Notes:
enrolled-keys
are enabled by default when Secure Boot is activated.loader secure='yes'
setting.For more details: community post.